Conversation
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
…ve related documentation Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
…e fixture Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
…ne test delay handling Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
…equirements Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the logging infrastructure to provide global configuration options, upgrades the testing framework from xUnit v2 to v3, updates documentation references from FluentAssertions to AwesomeAssertions, and improves code organization across the project.
Changes:
- Introduces a new global logging configuration system (
LogOptions) that allows library consumers to configure logging via static properties, factory instances, or per-instance options - Upgrades test framework to xUnit v3 with enhanced features like
TestContext.Current.CancellationTokenand assembly fixtures - Removes redundant Husky.Net MSBuild targets (now using dotnet tools), SourceLink from application projects, and replaces
#pragmadirectives withSuppressMessageattributes following coding guidelines - Adds comprehensive documentation files (CODESTYLE.md, AGENTS.md) and updates existing documentation to reflect AwesomeAssertions usage
Reviewed changes
Copilot reviewed 29 out of 31 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Tests/Tests.csproj | Upgrades from xUnit v2 to v3 package reference |
| Tests/SampleTest.cs | Improves test naming, adds fixture inheritance, uses TestContext cancellation token |
| Tests/LoggingTests.cs | Adds comprehensive test coverage for new logging infrastructure |
| Tests/GlobalUsings.cs | Removes unused System.IO import |
| Tests/Fixture.cs | Implements assembly fixture and sequential collection patterns for xUnit v3 |
| Tests/.editorconfig | Adds suppressions for XML docs and CA1515 in test code |
| Library/LogOptions.cs | New global logging configuration class with thread-safe static properties |
| Library/Options.cs | New options class for per-instance logger configuration |
| Library/Library.cs | Refactored to use new logging options, adds StaticTemplateLibrary for static usage |
| Library/Extensions.cs | Changes extension methods from public to internal visibility |
| Library/Library.csproj | Removes Husky MSBuild target (now using dotnet tools) |
| Console/Program.cs | Updates to use new logging configuration API |
| Console/LoggerFactory.cs | Reorganizes code and adds CreateLoggerFactory method |
| Console/CommandLine.cs | Reorders fields to follow StyleCop-like conventions |
| Console/Extensions.cs | Removes redundant SuppressMessage attribute, relocates LogOverride class |
| Console/GlobalUsings.cs | Adds Microsoft.Extensions.Logging and Serilog.Events global usings |
| Console/Console.csproj | Removes SourceLink and Husky MSBuild target |
| Console/.editorconfig | Improves comment clarity |
| CodeGen/HttpClientFactory.cs | Enhances resilience handling to include exception detection |
| CodeGen/CommandLine.cs | Reorders fields to follow StyleCop-like conventions |
| CodeGen/CodeGen.csproj | Removes SourceLink and Husky MSBuild target |
| CodeGen/.editorconfig | Improves comment clarity |
| Benchmarks/SampleBenchmark.cs | Replaces #pragma with SuppressMessage attributes |
| Benchmarks/.editorconfig | Adds suppression for XML docs in benchmark code |
| CODESTYLE.md | New comprehensive code style and formatting reference |
| AGENTS.md | New AI coding agent instructions document |
| .github/copilot-instructions.md | Updates FluentAssertions references to AwesomeAssertions, adds new documentation sections |
| .editorconfig | Removes trailing whitespace |
| .config/dotnet-tools.json | Removes trailing newline |
| README.md | Reorganizes table of contents to group related sections |
| ProjectTemplate.code-workspace | Adds spelling exceptions for "Allman", "finalizers", and "LINQ" |
Sections for standards and references were unintentionally condensed into single lines with diff markers, reducing readability. No content was changed, but Markdown formatting was negatively affected.
…on; add Console Test launch configuration Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
… configuration Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
…g file output template format Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
…ole output Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
…and improve test cases Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
…ordering guidelines Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
…cumentation and tests for consistency Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
…readability Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
…ility in logger creation Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve code structure and documentation across multiple files, enhance the logging framework with global configuration options, and update the testing framework references. Additionally, reorganize the README to clarify branching workflow requirements.